ChangeSet 1.2449.2.6, 2004/11/04 10:54:31-08:00, tj@home-tj.org [PATCH] driver-model: sysfs_release() dangling pointer reference fix df_03_sysfs_release_fix.patch Some attributes are allocated dynamically (e.g. module and device parameters) and are usually deallocated when the assoicated kobject is released. So, it's not safe to access attr after putting the kobject. Signed-off-by: Tejun Heo Signed-off-by: Greg Kroah-Hartman fs/sysfs/file.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletion(-) diff -Nru a/fs/sysfs/file.c b/fs/sysfs/file.c --- a/fs/sysfs/file.c 2004-11-04 16:30:39 -08:00 +++ b/fs/sysfs/file.c 2004-11-04 16:30:39 -08:00 @@ -330,11 +330,13 @@ { struct kobject * kobj = to_kobj(filp->f_dentry->d_parent); struct attribute * attr = to_attr(filp->f_dentry); + struct module * owner = attr->owner; struct sysfs_buffer * buffer = filp->private_data; if (kobj) kobject_put(kobj); - module_put(attr->owner); + /* After this point, attr should not be accessed. */ + module_put(owner); if (buffer) { if (buffer->page)