ChangeSet 1.2449.2.8, 2004/11/04 10:57:45-08:00, tj@home-tj.org [PATCH] driver-model: device_add() error path reference counting fix df_05_device_add_ref_fix.patch In device_add(), @dev wan't put'd properly when it has zero length bus_id (error path). Fixed. Signed-off-by: Tejun Heo Signed-off-by: Greg Kroah-Hartman drivers/base/core.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff -Nru a/drivers/base/core.c b/drivers/base/core.c --- a/drivers/base/core.c 2004-11-04 16:30:24 -08:00 +++ b/drivers/base/core.c 2004-11-04 16:30:24 -08:00 @@ -209,12 +209,12 @@ */ int device_add(struct device *dev) { - struct device * parent; - int error; + struct device *parent = NULL; + int error = -EINVAL; dev = get_device(dev); if (!dev || !strlen(dev->bus_id)) - return -EINVAL; + goto Error; parent = get_device(dev->parent);